sync_fs = ocfs2_sync_fs,įs/overlayfs/super.c:399. sync_fs = hfsplus_sync_fs,įs/nilfs2/super.c:689. sync_fs = btrfs_sync_fs,įs/exfat/super.c:204. Return error in ->sync_fs() and these errors will be ignored too.įs/btrfs/super.c:2412. That error will simply be lost and sycnfs(overlay_fd), will getĪl Viro noticed that there are other filesystems which can sometimes It can return error if sync_filesystem() on upper super block failed. Ignoring ->sync_fs() return code is problematic for overlayfs where Subject: vfs: Do not ignore return code from s_op->sync_fsĬurrent implementation of _sync_filesystem() ignores the > I'm surprised that the compiler didn't complain that 'ret' might be used > + ret2 = _sync_blockdev(sb->s_bdev, wait) > - return _sync_blockdev(sb->s_bdev, wait) > writeback_inodes_sb(sb, WB_REASON_SYNC) > static int _sync_filesystem(struct super_block *sb, int wait) Re: vfs: Do not ignore return code from s_op->sync_fs - Vivek Goyal archive mirror help / color / mirror / Atom feed From: Vivek Goyal Ĭc: Re: vfs: Do not ignore return code from s_op->sync_fsĭate: Tue, 10:17:52 -0500
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |